fix(dashboard): scale-sweep drift chart no longer reads as permanent budget breach#149
Merged
Merged
Conversation
…budget breach The "Layout drift" trend (budget 25px) was fed only by scale-sweep rmsFromSavedPx, which measures how far force layout wanders synthetic seeded graphs from their seed positions — expected to grow with size, not a fidelity signal. The real 25px placed-graph fidelity guard is enforced in graph-perf.spec.ts. Retitle to "Layout wander vs size" and drop the misapplied budget so the dashboard stops showing a permanent 136px-vs-25px false breach. Same fix in the static perf report. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard "Layout drift" trend (budget 25px) is fed only by scale-sweep
rmsFromSavedPx, which measures how far force layout wanders synthetic seeded graphs from their seed positions — expected to grow with graph size, not a placed-graph fidelity signal. The real 25px fidelity guard lives ingraph-perf.spec.ts(enforced as a test assertion). Applying that budget on the dashboard made the chart read as a permanent 136px-vs-25px breach (a documented artifact, not a regression).This retitles the chart to "Layout wander vs size (scale sweep)" and drops the misapplied budget, in both the live dashboard and the static perf report.
Verification:
node --checkon both files +node --test tests/lib/dashboard/dashboard.test.mjs(39/39 pass). Framing-only change to informational charts; no app/data/graph paths touched.🤖 Generated with Claude Code